]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
scsi: fnic: Stop setting scsi_cmnd.tag
authorJohn Garry <john.garry@huawei.com>
Fri, 13 Aug 2021 13:49:12 +0000 (21:49 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 16 Aug 2021 17:33:24 +0000 (13:33 -0400)
It is never read. Setting it and the request tag seems dodgy anyway.

Link: https://lore.kernel.org/r/1628862553-179450-3-git-send-email-john.garry@huawei.com
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/fnic/fnic_scsi.c

index 0f9cedf7887270873d0b9ff89f594f9ddff4994a..f8afbfb468dcadbc5dfa7637d067b6c19ea65c46 100644 (file)
@@ -2213,7 +2213,7 @@ fnic_scsi_host_start_tag(struct fnic *fnic, struct scsi_cmnd *sc)
        if (IS_ERR(dummy))
                return SCSI_NO_TAG;
 
-       sc->tag = rq->tag = dummy->tag;
+       rq->tag = dummy->tag;
        sc->host_scribble = (unsigned char *)dummy;
 
        return dummy->tag;