]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
clk: ti: clkctrl: Fix Bad of_node_put within clkctrl_get_name
authorTero Kristo <t-kristo@ti.com>
Fri, 24 Apr 2020 12:47:25 +0000 (15:47 +0300)
committerStephen Boyd <sboyd@kernel.org>
Wed, 13 May 2020 03:16:10 +0000 (20:16 -0700)
clkctrl_get_name incorrectly calls of_node_put when it is not really
doing of_node_get. This causes a boot time warning later on:

[    0.000000] OF: ERROR: Bad of_node_put() on /ocp/interconnect@4a000000/segmen
t@0/target-module@5000/cm_core_aon@0/ipu-cm@500/ipu1-clkctrl@20

Fix by dropping the of_node_put from the function.

Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Fixes: 6c3090520554 ("clk: ti: clkctrl: Fix hidden dependency to node name")
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Link: https://lkml.kernel.org/r/20200424124725.9895-1-t-kristo@ti.com
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/ti/clkctrl.c

index 062266034d84669a40455020c91374c59c492996..9019624e37bc9fd7f19c25f44d347279cd22352a 100644 (file)
@@ -461,7 +461,6 @@ static char * __init clkctrl_get_name(struct device_node *np)
                        return name;
                }
        }
-       of_node_put(np);
 
        return NULL;
 }