crypto: caam - Kill SPRINTFCAT() with fire

This macro is just like an encyclopedia of string handling done wrong.
This must die. This is so wrong on so many levels.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Horia Geanta <horia.geanta@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/caam/error.c b/drivers/crypto/caam/error.c
index 66a7461cf9aed888ed5fa0c41f98aad54bf4e81a..7ed2e4fb3c15f50ca1491192014107922313bfab 100644 (file)
--- a/drivers/crypto/caam/error.c
+++ b/drivers/crypto/caam/error.c
@@ -158,16 +158,6 @@ static const char * const rng_err_id_list[] = {
        "Secure key generation",
 };
 
-#define SPRINTFCAT(str, format, param, max_alloc)              \
-{                                                              \
-       char *tmp;                                              \
-                                                               \
-       tmp = kmalloc(sizeof(format) + max_alloc, GFP_ATOMIC);  \
-       sprintf(tmp, format, param);                            \
-       strcat(str, tmp);                                       \
-       kfree(tmp);                                             \
-}
-
 static void report_ccb_status(struct device *jrdev, u32 status,
                              const char *error, char *__outstr)
 {