]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
bonding: avoid printing while holding a spinlock
authorMahesh Bandewar <maheshb@google.com>
Mon, 27 Mar 2017 18:37:40 +0000 (11:37 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 28 Mar 2017 04:11:50 +0000 (21:11 -0700)
Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_3ad.c

index 508713b4e53381dffdd90faa0dd395f82b87b93a..c5fd4259da331b27503644938ab22787e2eea8ae 100644 (file)
@@ -2446,9 +2446,9 @@ void bond_3ad_adapter_speed_duplex_changed(struct slave *slave)
 
        spin_lock_bh(&slave->bond->mode_lock);
        ad_update_actor_keys(port, false);
+       spin_unlock_bh(&slave->bond->mode_lock);
        netdev_dbg(slave->bond->dev, "Port %d slave %s changed speed/duplex\n",
                   port->actor_port_number, slave->dev->name);
-       spin_unlock_bh(&slave->bond->mode_lock);
 }
 
 /**
@@ -2492,12 +2492,12 @@ void bond_3ad_handle_link_change(struct slave *slave, char link)
        agg = __get_first_agg(port);
        ad_agg_selection_logic(agg, &dummy);
 
+       spin_unlock_bh(&slave->bond->mode_lock);
+
        netdev_dbg(slave->bond->dev, "Port %d changed link status to %s\n",
                   port->actor_port_number,
                   link == BOND_LINK_UP ? "UP" : "DOWN");
 
-       spin_unlock_bh(&slave->bond->mode_lock);
-
        /* RTNL is held and mode_lock is released so it's safe
         * to update slave_array here.
         */