]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
mfd: lpc_ich: Fix resource request for [mem 0x00000000]
authorPeter Hurley <peter@hurleysoftware.com>
Wed, 21 Nov 2012 16:30:50 +0000 (17:30 +0100)
committerSamuel Ortiz <sameo@linux.intel.com>
Wed, 21 Nov 2012 16:31:20 +0000 (17:31 +0100)
The older southbridges supported by the lpc_ich driver do not
provide memory-mapped space of the root complex. The driver
correctly avoids computing the iomem address in this case, yet
submits a zeroed resource request anyway (via mfd_add_devices()).

Remove the iomem resource from the resource array submitted to the
mfd core for the older southbridges.

Acked-by: Aaron Sierra <asierra@xes-inc.com>
Cc: Peter Tyser <ptyser@xes-inc.com>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/lpc_ich.c

index a22544fe53197904f56f0c67f87970ddd727caf5..afb2f77a9ae8641bbbfd76e97b3ee3e07628b025 100644 (file)
@@ -830,7 +830,10 @@ static int __devinit lpc_ich_init_wdt(struct pci_dev *dev,
         * we have to read RCBA from PCI Config space 0xf0 and use
         * it as base. GCS = RCBA + ICH6_GCS(0x3410).
         */
-       if (lpc_chipset_info[id->driver_data].iTCO_version == 2) {
+       if (lpc_chipset_info[id->driver_data].iTCO_version == 1) {
+               /* Don't register iomem for TCO ver 1 */
+               lpc_ich_cells[LPC_WDT].num_resources--;
+       } else {
                pci_read_config_dword(dev, RCBABASE, &base_addr_cfg);
                base_addr = base_addr_cfg & 0xffffc000;
                if (!(base_addr_cfg & 1)) {