irqchip/nvic: Release nvic_base upon failure

BugLink: https://bugs.launchpad.net/bugs/1969110
[ Upstream commit e414c25e3399b2b3d7337dc47abccab5c71b7c8f ]

smatch warning was reported as below ->

smatch warnings:
drivers/irqchip/irq-nvic.c:131 nvic_of_init()
warn: 'nvic_base' not released on lines: 97.

Release nvic_base upon failure.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220218163303.33344-1-jrdr.linux@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 757322b5aba928afb98594e972168c39deaa9161)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c
index 599bb6fc5f0a2f9e0217fd3f7b199ef48e3ad18c..47b3b165479e87ad05b1f698a89ca203bb0b8840 100644 (file)
--- a/drivers/irqchip/irq-nvic.c
+++ b/drivers/irqchip/irq-nvic.c
@@ -92,6 +92,7 @@ static int __init nvic_of_init(struct device_node *node,
 
        if (!nvic_irq_domain) {
                pr_warn("Failed to allocate irq domain\n");
+               iounmap(nvic_base);
                return -ENOMEM;
        }
 
@@ -101,6 +102,7 @@ static int __init nvic_of_init(struct device_node *node,
        if (ret) {
                pr_warn("Failed to allocate irq chips\n");
                irq_domain_remove(nvic_irq_domain);
+               iounmap(nvic_base);
                return ret;
        }