]> git.proxmox.com Git - mirror_frr.git/commitdiff
bgpd: use "assert" for one check on evpn-mh
authoranlan_cs <vic.lan@pica8.com>
Fri, 1 Apr 2022 06:22:24 +0000 (02:22 -0400)
committeranlan_cs <vic.lan@pica8.com>
Fri, 1 Apr 2022 06:51:36 +0000 (02:51 -0400)
"no ead-es-route-target export RT":
Since existance is already checked in `bgp_evpn_ead_es_rt_cmd`
with `bgp_evpn_rt_matches_existing()`, there MUST be a deleting
node in evpn's `bgp_mh_info->ead_es_export_rtl` list.

Just modify the check for deleting node to an `assert`.

Signed-off-by: anlan_cs <vic.lan@pica8.com>
bgpd/bgp_evpn_mh.c

index ed3716f60123f0ba5b1c1d9e9542324f4906d81f..d73186979d27940cc79c0df555a9b2b362cfcf46 100644 (file)
@@ -1273,9 +1273,9 @@ void bgp_evpn_mh_config_ead_export_rt(struct bgp *bgp,
                                }
                        }
 
-                       if (node_to_del)
-                               list_delete_node(bgp_mh_info->ead_es_export_rtl,
-                                                node_to_del);
+                       assert(node_to_del);
+                       list_delete_node(bgp_mh_info->ead_es_export_rtl,
+                                        node_to_del);
                }
        } else {
                listnode_add_sort(bgp_mh_info->ead_es_export_rtl, ecomcfg);