nvme: Detect and warn users with the broken firmware 3B2QGXA7

diff --git a/plugins/nvme/README.md b/plugins/nvme/README.md
index 0c50bbc6f684521fc9ec81eaa3d67d6cb0482bfc..14765ae35fcf7ce2cc2da34e8415951ff1abe476 100644 (file)
--- a/plugins/nvme/README.md
+++ b/plugins/nvme/README.md
@@ -32,6 +32,10 @@ The FRU globally unique identifier (FGUID) is also added from the CNS if set.
 Please refer to this document for more details on how to add support for
 [FGUID](https://nvmexpress.org/wp-content/uploads/NVM_Express_Revision_1.3.pdf).
 
+Additionally, an extra instance IDs containing the version may be added.
+
+* `NVME\VEN_1179&DEV_010F&VER_3B2QGXA7`
+
 Additionally, for NVMe drives with Dell vendor firmware two extra GUIDs are
 added:
 

diff --git a/plugins/nvme/fu-nvme-device.c b/plugins/nvme/fu-nvme-device.c
index 2e731d9955b00994b150039446863e7a032b5939..47cee7e5b19a95f11d58c85c91d290315cd60a8f 100644 (file)
--- a/plugins/nvme/fu-nvme-device.c
+++ b/plugins/nvme/fu-nvme-device.c
@@ -348,6 +348,10 @@ fu_nvme_device_setup(FuDevice *device, GError **error)
        if (!fu_nvme_device_parse_cns(self, buf, sizeof(buf), error))
                return FALSE;
 
+       /* add one extra instance ID so that we can match bad firmware */
+       fu_device_add_instance_strsafe(device, "VER", fu_device_get_version(device));
+       fu_device_build_instance_id_quirk(device, NULL, "NVME", "VEN", "DEV", "VER", NULL);
+
        /* success */
        return TRUE;
 }

diff --git a/plugins/nvme/nvme.quirk b/plugins/nvme/nvme.quirk
index 66d196a962392a124a3322a3a4403aeb7efb8437..da513622f1ebb9af32d82c4797719cf2b49b1b5c 100644 (file)
--- a/plugins/nvme/nvme.quirk
+++ b/plugins/nvme/nvme.quirk
@@ -47,3 +47,8 @@ Flags = signed-payload
 # Solidigm
 [NVME\VEN_025E&DEV_F1AB]
 Flags = needs-shutdown
+
+[NVME\VEN_144D&DEV_A80A&VER_2B2QGXA7]
+Issue = https://www.pugetsystems.com/support/guides/critical-samsung-ssd-firmware-update/
+[NVME\VEN_144D&DEV_A80A&VER_3B2QGXA7]
+Issue = https://www.pugetsystems.com/support/guides/critical-samsung-ssd-firmware-update/