]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: dpaa2-eth: use dev_close/open instead of the internal functions
authorIoana Ciornei <ioana.ciornei@nxp.com>
Tue, 18 Oct 2022 14:18:56 +0000 (17:18 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Oct 2022 08:22:11 +0000 (09:22 +0100)
Instead of calling the internal functions which implement .ndo_stop and
.ndo_open, we can simply call dev_close and dev_open, so that we keep
the code cleaner.

Also, in the next patches we'll use the same APIs from other files
without needing to export the internal functions.

Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c

index 1213ae4e1301e5a4eeaf81a7c16ba7181022a9b8..b95e9a7123e01eb0bcaab7966c2edbd727f26b47 100644 (file)
@@ -2626,7 +2626,7 @@ static int dpaa2_eth_setup_xdp(struct net_device *dev, struct bpf_prog *prog)
        need_update = (!!priv->xdp_prog != !!prog);
 
        if (up)
-               dpaa2_eth_stop(dev);
+               dev_close(dev);
 
        /* While in xdp mode, enforce a maximum Rx frame size based on MTU.
         * Also, when switching between xdp/non-xdp modes we need to reconfigure
@@ -2654,7 +2654,7 @@ static int dpaa2_eth_setup_xdp(struct net_device *dev, struct bpf_prog *prog)
        }
 
        if (up) {
-               err = dpaa2_eth_open(dev);
+               err = dev_open(dev, NULL);
                if (err)
                        return err;
        }
@@ -2665,7 +2665,7 @@ out_err:
        if (prog)
                bpf_prog_sub(prog, priv->num_channels);
        if (up)
-               dpaa2_eth_open(dev);
+               dev_open(dev, NULL);
 
        return err;
 }