HID: amd_sfh: Correct the stop all command

BugLink: https://bugs.launchpad.net/bugs/2025067
[ Upstream commit 82c2a0d137794f5ef47982231593a00aee26ce3b ]

Misinterpreted the stop all command in SHF1.1 firmware. Therefore, it is
necessary to update the stop all command accordingly to disable all
sensors.

Fixes: 93ce5e0231d7 ("HID: amd_sfh: Implement SFH1.1 functionality")
Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c
index 6e19ccc124508e476becf8ff092f6639020f3bcc..6f6047f7f12e96bf552a8e795cdf63ba12bbbe7d 100644 (file)
--- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c
+++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c
@@ -58,8 +58,10 @@ static void amd_stop_all_sensor(struct amd_mp2_dev *privdata)
        struct sfh_cmd_base cmd_base;
 
        cmd_base.ul = 0;
-       cmd_base.cmd.cmd_id = STOP_ALL_SENSORS;
+       cmd_base.cmd.cmd_id = DISABLE_SENSOR;
        cmd_base.cmd.intr_disable = 0;
+       /* 0xf indicates all sensors */
+       cmd_base.cmd.sensor_id = 0xf;
 
        writel(cmd_base.ul, privdata->mmio + AMD_C2P_MSG(0));
 }