]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
pwm: cros-ec: Fix transposed param settings
authorNick Vaccaro <nvaccaro@google.com>
Fri, 23 Jun 2017 21:52:47 +0000 (14:52 -0700)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 6 Jul 2017 15:16:37 +0000 (17:16 +0200)
The __cros_ec_pwm_get_duty() routine was transposing the insize and
outsize fields when calling cros_ec_cmd_xfer_status().

The original code worked without error due to size of the two particular
parameter blocks passed to cros_ec_cmd_xfer_status(), so this change is
not fixing an actual runtime problem, just correcting the calling usage.

Signed-off-by: Nick Vaccaro <nvaccaro@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-cros-ec.c

index f6ca4e8c6253f0ea8ccb9770045dcc16a142db10..9c13694eaa2480cdffba20b65049005a2d46ae24 100644 (file)
@@ -75,8 +75,8 @@ static int __cros_ec_pwm_get_duty(struct cros_ec_device *ec, u8 index,
 
        msg->version = 0;
        msg->command = EC_CMD_PWM_GET_DUTY;
-       msg->insize = sizeof(*params);
-       msg->outsize = sizeof(*resp);
+       msg->insize = sizeof(*resp);
+       msg->outsize = sizeof(*params);
 
        params->pwm_type = EC_PWM_TYPE_GENERIC;
        params->index = index;