]> git.proxmox.com Git - pmg-gui.git/commitdiff
refactor RelayDomains:
authorStoiko Ivanov <s.ivanov@proxmox.com>
Mon, 21 Oct 2019 17:23:36 +0000 (19:23 +0200)
committerDietmar Maurer <dietmar@proxmox.com>
Wed, 23 Oct 2019 09:50:04 +0000 (11:50 +0200)
by making the base-url, the description text and the online help anchor static
fields we can override it and reuse the component for DKIMDomains.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
js/RelayDomains.js

index 2cee2f5025d4598e15533c407ee9775257d607a5..042ba43f7bff0c9374ad5106b9acaccec9a93054 100644 (file)
@@ -2,10 +2,6 @@
 Ext.define('pmg-domains', {
     extend: 'Ext.data.Model',
     fields: [ 'domain', 'comment' ],
-    proxy: {
-        type: 'proxmox',
-       url: "/api2/json/config/domains"
-    },
     idProperty: 'domain'
 });
 
@@ -13,6 +9,11 @@ Ext.define('PMG.RelayDomains', {
     extend: 'Ext.grid.GridPanel',
     alias: ['widget.pmgRelayDomains'],
 
+    baseurl: '/config/domains',
+    domain_desc: gettext('Relay Domain'),
+
+    onlineHelp: 'pmgconfig_mailproxy_relay_domains',
+
     initComponent : function() {
        var me = this;
 
@@ -21,7 +22,11 @@ Ext.define('PMG.RelayDomains', {
            sorters: {
                property: 'domain',
                order: 'DESC'
-           }
+           },
+           proxy: {
+               type: 'proxmox',
+               url: '/api2/json' + me.baseurl
+           },
        });
 
         var reload = function() {
@@ -32,7 +37,7 @@ Ext.define('PMG.RelayDomains', {
 
        var remove_btn = Ext.createWidget('proxmoxStdRemoveButton', {
            selModel: me.selModel,
-           baseurl: '/config/domains',
+           baseurl: me.baseurl,
            callback: reload,
            waitMsgTarget: me
        });
@@ -44,15 +49,15 @@ Ext.define('PMG.RelayDomains', {
            }
 
            var config = {
-               url: "/api2/extjs/config/domains/" + rec.data.domain,
-               onlineHelp: 'pmgconfig_mailproxy_relay_domains',
+               url: '/api2/extjs' + me.baseurl + '/' + rec.data.domain,
+               onlineHelp: me.onlineHelp,
                method: 'PUT',
-               subject: gettext("Relay Domain"),
+               subject: me.domain_desc,
                items: [
                    {
                        xtype: 'displayfield',
                        name: 'domain',
-                       fieldLabel: gettext("Relay Domain")
+                       fieldLabel: me.domain_desc
                    },
                    {
                        xtype: 'textfield',
@@ -83,15 +88,15 @@ Ext.define('PMG.RelayDomains', {
                    /*jslint confusion: true*/
                    var config = {
                        method: 'POST',
-                       url: "/api2/extjs/config/domains",
-                       onlineHelp: 'pmgconfig_mailproxy_relay_domains',
+                       url: '/api2/extjs' + me.baseurl,
+                       onlineHelp: me.onlineHelp,
                        isCreate: true,
                        subject: gettext("Relay Domain"),
                        items: [
                            {
                                xtype: 'proxmoxtextfield',
                                name: 'domain',
-                               fieldLabel: gettext("Relay Domain")
+                               fieldLabel: me.domain_desc
                            },
                            {
                                xtype: 'proxmoxtextfield',
@@ -122,7 +127,7 @@ Ext.define('PMG.RelayDomains', {
            },
            columns: [
                {
-                   header: gettext('Relay Domain'),
+                   header: me.domain_desc,
                    width: 200,
                    sortable: true,
                    dataIndex: 'domain'