]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
tridentfb: use display information in info not in var for panning
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Tue, 14 Jun 2011 09:25:02 +0000 (09:25 +0000)
committerPaul Mundt <lethal@linux-sh.org>
Wed, 15 Jun 2011 06:03:50 +0000 (15:03 +0900)
We must not use any information in the passed var besides xoffset,
yoffset and vmode as otherwise applications might abuse it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
drivers/video/tridentfb.c

index c6c77562839d9663cef133f9b23e0d1607a5d2c8..34cf019bba44b64dc9c5a09ec4683efac8ff262c 100644 (file)
@@ -987,8 +987,8 @@ static int tridentfb_pan_display(struct fb_var_screeninfo *var,
        unsigned int offset;
 
        debug("enter\n");
-       offset = (var->xoffset + (var->yoffset * var->xres_virtual))
-               * var->bits_per_pixel / 32;
+       offset = (var->xoffset + (var->yoffset * info->var.xres_virtual))
+               * info->var.bits_per_pixel / 32;
        set_screen_start(par, offset);
        debug("exit\n");
        return 0;