]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
staging: comedi: cb_pcidas: tidy up dac08 calibration subdevice
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Wed, 14 Oct 2015 00:47:53 +0000 (17:47 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 17 Oct 2015 06:20:10 +0000 (23:20 -0700)
For aesthetics, add some whitespace to the subdevice init.

It's not possible to actually read from the dac08. For convienence
the subdevice readback provided by the core is used to return the
last value written to the subdevice. Remove the SDF_READABLE flag
from the subdev_flags.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/cb_pcidas.c

index fc972e56a62382414d19d6fd8f86d32064422a2a..b5c7dc3a9c6bff22dbafede6b36a919859f8b673 100644 (file)
@@ -1415,14 +1415,14 @@ static int cb_pcidas_auto_attach(struct comedi_device *dev,
                s->readback[i] = s->maxdata / 2;
        }
 
-       /*  dac08 caldac */
+       /* Calibration subdevice - dac08 caldac */
        s = &dev->subdevices[6];
        if (board->has_dac08) {
-               s->type = COMEDI_SUBD_CALIB;
-               s->subdev_flags = SDF_READABLE | SDF_WRITABLE | SDF_INTERNAL;
-               s->n_chan = 1;
-               s->maxdata = 0xff;
-               s->insn_write = cb_pcidas_dac08_insn_write;
+               s->type         = COMEDI_SUBD_CALIB;
+               s->subdev_flags = SDF_WRITABLE | SDF_INTERNAL;
+               s->n_chan       = 1;
+               s->maxdata      = 0xff;
+               s->insn_write   = cb_pcidas_dac08_insn_write;
 
                ret = comedi_alloc_subdev_readback(s);
                if (ret)
@@ -1433,7 +1433,7 @@ static int cb_pcidas_auto_attach(struct comedi_device *dev,
                        s->readback[i] = s->maxdata / 2;
                }
        } else {
-               s->type = COMEDI_SUBD_UNUSED;
+               s->type         = COMEDI_SUBD_UNUSED;
        }
 
        /*  make sure mailbox 4 is empty */