scsi: target: Use kstrtobool() instead of strtobool()

strtobool() is the same as kstrtobool().  However, the latter is more used
within the kernel.

In order to remove strtobool() and slightly simplify kstrtox.h, switch to
the other function name.

While at it, include the corresponding header file (<linux/kstrtox.h>)

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/fcddc0a53b4fc6e3c2e93592d3f61c5c63121855.1667336095.git.christophe.jaillet@wanadoo.fr
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index 533524299ed6b5c1a4f6edd6b6c0455233015fb2..b8a5c8d6cfde0e88b74b5bd6622a1e726e8ecd6b 100644 (file)
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -12,6 +12,7 @@
  *
  ****************************************************************************/
 
+#include <linux/kstrtox.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <generated/utsrelease.h>
@@ -578,7 +579,7 @@ static ssize_t _name##_store(struct config_item *item, const char *page,    \
        bool flag;                                                      \
        int ret;                                                        \
                                                                        \
-       ret = strtobool(page, &flag);                                   \
+       ret = kstrtobool(page, &flag);                                  \
        if (ret < 0)                                                    \
                return ret;                                             \
        da->_name = flag;                                               \
@@ -638,7 +639,7 @@ static ssize_t emulate_model_alias_store(struct config_item *item,
                return -EINVAL;
        }
 
-       ret = strtobool(page, &flag);
+       ret = kstrtobool(page, &flag);
        if (ret < 0)
                return ret;
 
@@ -660,7 +661,7 @@ static ssize_t emulate_write_cache_store(struct config_item *item,
        bool flag;
        int ret;
 
-       ret = strtobool(page, &flag);
+       ret = kstrtobool(page, &flag);
        if (ret < 0)
                return ret;
 
@@ -712,7 +713,7 @@ static ssize_t emulate_tas_store(struct config_item *item,
        bool flag;
        int ret;
 
-       ret = strtobool(page, &flag);
+       ret = kstrtobool(page, &flag);
        if (ret < 0)
                return ret;
 
@@ -737,7 +738,7 @@ static ssize_t emulate_tpu_store(struct config_item *item,
        bool flag;
        int ret;
 
-       ret = strtobool(page, &flag);
+       ret = kstrtobool(page, &flag);
        if (ret < 0)
                return ret;
 
@@ -767,7 +768,7 @@ static ssize_t emulate_tpws_store(struct config_item *item,
        bool flag;
        int ret;
 
-       ret = strtobool(page, &flag);
+       ret = kstrtobool(page, &flag);
        if (ret < 0)
                return ret;
 
@@ -866,7 +867,7 @@ static ssize_t pi_prot_format_store(struct config_item *item,
        bool flag;
        int ret;
 
-       ret = strtobool(page, &flag);
+       ret = kstrtobool(page, &flag);
        if (ret < 0)
                return ret;
 
@@ -903,7 +904,7 @@ static ssize_t pi_prot_verify_store(struct config_item *item,
        bool flag;
        int ret;
 
-       ret = strtobool(page, &flag);
+       ret = kstrtobool(page, &flag);
        if (ret < 0)
                return ret;
 
@@ -932,7 +933,7 @@ static ssize_t force_pr_aptpl_store(struct config_item *item,
        bool flag;
        int ret;
 
-       ret = strtobool(page, &flag);
+       ret = kstrtobool(page, &flag);
        if (ret < 0)
                return ret;
        if (da->da_dev->export_count) {
@@ -954,7 +955,7 @@ static ssize_t emulate_rest_reord_store(struct config_item *item,
        bool flag;
        int ret;
 
-       ret = strtobool(page, &flag);
+       ret = kstrtobool(page, &flag);
        if (ret < 0)
                return ret;
 
@@ -977,7 +978,7 @@ static ssize_t unmap_zeroes_data_store(struct config_item *item,
        bool flag;
        int ret;
 
-       ret = strtobool(page, &flag);
+       ret = kstrtobool(page, &flag);
        if (ret < 0)
                return ret;
 
@@ -1126,7 +1127,7 @@ static ssize_t alua_support_store(struct config_item *item,
        bool flag, oldflag;
        int ret;
 
-       ret = strtobool(page, &flag);
+       ret = kstrtobool(page, &flag);
        if (ret < 0)
                return ret;
 
@@ -1165,7 +1166,7 @@ static ssize_t pgr_support_store(struct config_item *item,
        bool flag, oldflag;
        int ret;
 
-       ret = strtobool(page, &flag);
+       ret = kstrtobool(page, &flag);
        if (ret < 0)
                return ret;
 
@@ -1194,7 +1195,7 @@ static ssize_t emulate_rsoc_store(struct config_item *item,
        bool flag;
        int ret;
 
-       ret = strtobool(page, &flag);
+       ret = kstrtobool(page, &flag);
        if (ret < 0)
                return ret;
 

diff --git a/drivers/target/target_core_fabric_configfs.c b/drivers/target/target_core_fabric_configfs.c
index 95a88f6224cd969f5ab3ae4d719669b9c5e4e3f4..67b18a67317a053720efc28a325d036be1d54be5 100644 (file)
--- a/drivers/target/target_core_fabric_configfs.c
+++ b/drivers/target/target_core_fabric_configfs.c
@@ -11,6 +11,7 @@
 *
  ****************************************************************************/
 
+#include <linux/kstrtox.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/utsname.h>
@@ -829,7 +830,7 @@ static ssize_t target_fabric_tpg_base_enable_store(struct config_item *item,
        int ret;
        bool op;
 
-       ret = strtobool(page, &op);
+       ret = kstrtobool(page, &op);
        if (ret)
                return ret;