driver core: Establish order of operations for device_add and device_del via bitflag

BugLink: https://bugs.launchpad.net/bugs/1840378
commit 3451a495ef244a88ed6317a035299d835554d579 upstream.

Add an additional bit flag to the device_private struct named "dead".

This additional flag provides a guarantee that when a device_del is
executed on a given interface an async worker will not attempt to attach
the driver following the earlier device_del call. Previously this
guarantee was not present and could result in the device_del call
attempting to remove a driver from an interface only to have the async
worker attempt to probe the driver later when it finally completes the
asynchronous probe call.

One additional change added was that I pulled the check for dev->driver
out of the __device_attach_driver call and instead placed it in the
__device_attach_async_helper call. This was motivated by the fact that the
only other caller of this, __device_attach, had already taken the
device_lock() and checked for dev->driver. Instead of testing for this
twice in this path it makes more sense to just consolidate the dev->dead
and dev->driver checks together into one set of checks.

Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

diff --git a/drivers/base/base.h b/drivers/base/base.h
index d800de650fa56bc264b8465621e12c829b01d60d..53b33580869128a992dedc76a3c77ccd821bd1eb 100644 (file)
--- a/drivers/base/base.h
+++ b/drivers/base/base.h
@@ -66,6 +66,9 @@ struct driver_private {
  *     probed first.
  * @device - pointer back to the struct device that this structure is
  * associated with.
+ * @dead - This device is currently either in the process of or has been
+ *     removed from the system. Any asynchronous events scheduled for this
+ *     device should exit without taking any action.
  *
  * Nothing outside of the driver core should ever touch these fields.
  */
@@ -76,6 +79,7 @@ struct device_private {
        struct klist_node knode_bus;
        struct list_head deferred_probe;
        struct device *device;
+       u8 dead:1;
 };
 #define to_device_private_parent(obj)  \
        container_of(obj, struct device_private, knode_parent)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 2aeeb4bb09b91e42116016b1f621fdd0a643b6a3..dff1ef65d768180a97fd3ce56ec36a32a10213b9 100644 (file)
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -1983,6 +1983,17 @@ void device_del(struct device *dev)
        struct kobject *glue_dir = NULL;
        struct class_interface *class_intf;
 
+       /*
+        * Hold the device lock and set the "dead" flag to guarantee that
+        * the update behavior is consistent with the other bitfields near
+        * it and that we cannot have an asynchronous probe routine trying
+        * to run while we are tearing out the bus/class/sysfs from
+        * underneath the device.
+        */
+       device_lock(dev);
+       dev->p->dead = true;
+       device_unlock(dev);
+
        /* Notify clients of device removal.  This call must come
         * before dpm_sysfs_remove().
         */

diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 4551b7a2ed92417d282b5a4763f584c70dcffc2b..4820b29dbe5c4b2e822541f9424ba63a77681c6f 100644 (file)
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -621,15 +621,6 @@ static int __device_attach_driver(struct device_driver *drv, void *_data)
        bool async_allowed;
        int ret;
 
-       /*
-        * Check if device has already been claimed. This may
-        * happen with driver loading, device discovery/registration,
-        * and deferred probe processing happens all at once with
-        * multiple threads.
-        */
-       if (dev->driver)
-               return -EBUSY;
-
        ret = driver_match_device(drv, dev);
        if (ret == 0) {
                /* no match */
@@ -664,6 +655,15 @@ static void __device_attach_async_helper(void *_dev, async_cookie_t cookie)
 
        device_lock(dev);
 
+       /*
+        * Check if device has already been removed or claimed. This may
+        * happen with driver loading, device discovery/registration,
+        * and deferred probe processing happens all at once with
+        * multiple threads.
+        */
+       if (dev->p->dead || dev->driver)
+               goto out_unlock;
+
        if (dev->parent)
                pm_runtime_get_sync(dev->parent);
 
@@ -674,7 +674,7 @@ static void __device_attach_async_helper(void *_dev, async_cookie_t cookie)
 
        if (dev->parent)
                pm_runtime_put(dev->parent);
-
+out_unlock:
        device_unlock(dev);
 
        put_device(dev);
@@ -787,7 +787,7 @@ static int __driver_attach(struct device *dev, void *data)
        if (dev->parent)        /* Needed for USB */
                device_lock(dev->parent);
        device_lock(dev);
-       if (!dev->driver)
+       if (!dev->p->dead && !dev->driver)
                driver_probe_device(drv, dev);
        device_unlock(dev);
        if (dev->parent)