]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
cxgb4: make the array match_all_mac static, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Sun, 1 Aug 2021 15:12:05 +0000 (16:12 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 2 Aug 2021 22:01:26 +0000 (15:01 -0700)
Don't populate the array match_all_mac on the stack but instead it
static const. Makes the object code smaller by 75 bytes.

Before:
   text    data     bss     dec     hex filename
  46701    8960      64   55725    d9ad ../chelsio/cxgb4/cxgb4_filter.o

After:
   text    data     bss     dec     hex filename
  46338    9120     192   55650    d962 ../chelsio/cxgb4/cxgb4_filter.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210801151205.145924-1-colin.king@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c

index 6260b3bebd2bd13afce7bbfc9811ac47123a51da..786ceae3448875666135a34549a062b6809fc503 100644 (file)
@@ -1441,7 +1441,7 @@ static int cxgb4_set_hash_filter(struct net_device *dev,
        } else if (iconf & USE_ENC_IDX_F) {
                if (f->fs.val.encap_vld) {
                        struct port_info *pi = netdev_priv(f->dev);
-                       u8 match_all_mac[] = { 0, 0, 0, 0, 0, 0 };
+                       static const u8 match_all_mac[] = { 0, 0, 0, 0, 0, 0 };
 
                        /* allocate MPS TCAM entry */
                        ret = t4_alloc_encap_mac_filt(adapter, pi->viid,
@@ -1688,7 +1688,7 @@ int __cxgb4_set_filter(struct net_device *dev, int ftid,
        } else if (iconf & USE_ENC_IDX_F) {
                if (f->fs.val.encap_vld) {
                        struct port_info *pi = netdev_priv(f->dev);
-                       u8 match_all_mac[] = { 0, 0, 0, 0, 0, 0 };
+                       static const u8 match_all_mac[] = { 0, 0, 0, 0, 0, 0 };
 
                        /* allocate MPS TCAM entry */
                        ret = t4_alloc_encap_mac_filt(adapter, pi->viid,