]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
Revert "drm/panfrost: Use drm_gem_map_offset()"
authorRob Herring <robh@kernel.org>
Wed, 7 Aug 2019 14:52:48 +0000 (10:52 -0400)
committerSean Paul <seanpaul@chromium.org>
Wed, 7 Aug 2019 15:56:48 +0000 (11:56 -0400)
This reverts commit 583bbf46133c726bae277e8f4e32bfba2a528c7f.

Turns out we need mmap to work on imported BOs even if the current code
is buggy.

Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sean Paul <sean@poorly.run>
Link: https://patchwork.freedesktop.org/patch/msgid/20190807145253.2037-3-sean@poorly.run
drivers/gpu/drm/panfrost/panfrost_drv.c

index b2e325e270b7adbab8a62cee64ecc1086823e748..b187daa4da856661b808981e310327241df0769b 100644 (file)
@@ -291,14 +291,26 @@ static int panfrost_ioctl_mmap_bo(struct drm_device *dev, void *data,
                      struct drm_file *file_priv)
 {
        struct drm_panfrost_mmap_bo *args = data;
+       struct drm_gem_object *gem_obj;
+       int ret;
 
        if (args->flags != 0) {
                DRM_INFO("unknown mmap_bo flags: %d\n", args->flags);
                return -EINVAL;
        }
 
-       return drm_gem_map_offset(file_priv, dev, args->handle,
-                                      &args->offset);
+       gem_obj = drm_gem_object_lookup(file_priv, args->handle);
+       if (!gem_obj) {
+               DRM_DEBUG("Failed to look up GEM BO %d\n", args->handle);
+               return -ENOENT;
+       }
+
+       ret = drm_gem_create_mmap_offset(gem_obj);
+       if (ret == 0)
+               args->offset = drm_vma_node_offset_addr(&gem_obj->vma_node);
+       drm_gem_object_put_unlocked(gem_obj);
+
+       return ret;
 }
 
 static int panfrost_ioctl_get_bo_offset(struct drm_device *dev, void *data,