]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
cfq-iosched: fix bad return value cfq_should_preempt()
authorJens Axboe <jens.axboe@oracle.com>
Tue, 3 Nov 2009 19:21:35 +0000 (20:21 +0100)
committerJens Axboe <jens.axboe@oracle.com>
Tue, 3 Nov 2009 19:21:35 +0000 (20:21 +0100)
Commit a6151c3a5c8e1ff5a28450bc8d6a99a2a0add0a7 inadvertently reversed
a preempt condition check, potentially causing a performance regression.
Make the meta check correct again.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
block/cfq-iosched.c

index 069a61017c02c9ee4307a43ba97786f86a1ec196..5802e322b7ad31cb7c0e2ea9c3b39ada3b5baa65 100644 (file)
@@ -2051,7 +2051,7 @@ cfq_should_preempt(struct cfq_data *cfqd, struct cfq_queue *new_cfqq,
         * it's a metadata request and the current queue is doing regular IO.
         */
        if (rq_is_meta(rq) && !cfqq->meta_pending)
-               return false;
+               return true;
 
        /*
         * Allow an RT request to pre-empt an ongoing non-RT cfqq timeslice.