]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
drm/amdgpu/powerplay: fix NULL pointer issue when SMU disabled
authorLikun Gao <Likun.Gao@amd.com>
Wed, 25 Dec 2019 09:42:35 +0000 (17:42 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 7 Jan 2020 16:57:28 +0000 (11:57 -0500)
Fix smu related NULL pointer issue which occurs when SMU is disabled.

Signed-off-by: Likun Gao <Likun.Gao@amd.com>
Reviewed-by: Evan Quan <evan.quan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c

index d04c0ae3cfaab815b87a642987a432f442d383c8..e51cf5a151e85e342d43bd4f0a89178b5ecb636d 100644 (file)
@@ -1904,8 +1904,14 @@ int smu_write_watermarks_table(struct smu_context *smu)
 int smu_set_watermarks_for_clock_ranges(struct smu_context *smu,
                struct dm_pp_wm_sets_with_clock_ranges_soc15 *clock_ranges)
 {
-       struct smu_table *watermarks = &smu->smu_table.tables[SMU_TABLE_WATERMARKS];
-       void *table = watermarks->cpu_addr;
+       struct smu_table *watermarks;
+       void *table;
+
+       if (!smu->smu_table.tables)
+               return 0;
+
+       watermarks = &smu->smu_table.tables[SMU_TABLE_WATERMARKS];
+       table = watermarks->cpu_addr;
 
        mutex_lock(&smu->mutex);
 
@@ -2397,7 +2403,7 @@ bool smu_baco_is_support(struct smu_context *smu)
 
        mutex_lock(&smu->mutex);
 
-       if (smu->ppt_funcs->baco_is_support)
+       if (smu->ppt_funcs && smu->ppt_funcs->baco_is_support)
                ret = smu->ppt_funcs->baco_is_support(smu);
 
        mutex_unlock(&smu->mutex);