]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
nvmem: use octal permissions instead of constants
authorBartosz Golaszewski <bgolaszewski@baylibre.com>
Fri, 21 Sep 2018 13:40:24 +0000 (06:40 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Sep 2018 13:14:55 +0000 (15:14 +0200)
Checkpatch emits a warning when using symbolic permissions. Use octal
permissions instead.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/nvmem/core.c

index e44a1860a2b375f7e18d17229d0c0f2a1b5eda93..ad1227df1984a543d4016940024ca81f085a3dce 100644 (file)
@@ -154,7 +154,7 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj,
 static struct bin_attribute bin_attr_rw_nvmem = {
        .attr   = {
                .name   = "nvmem",
-               .mode   = S_IWUSR | S_IRUGO,
+               .mode   = 0644,
        },
        .read   = bin_attr_nvmem_read,
        .write  = bin_attr_nvmem_write,
@@ -178,7 +178,7 @@ static const struct attribute_group *nvmem_rw_dev_groups[] = {
 static struct bin_attribute bin_attr_ro_nvmem = {
        .attr   = {
                .name   = "nvmem",
-               .mode   = S_IRUGO,
+               .mode   = 0444,
        },
        .read   = bin_attr_nvmem_read,
 };
@@ -201,7 +201,7 @@ static const struct attribute_group *nvmem_ro_dev_groups[] = {
 static struct bin_attribute bin_attr_rw_root_nvmem = {
        .attr   = {
                .name   = "nvmem",
-               .mode   = S_IWUSR | S_IRUSR,
+               .mode   = 0600,
        },
        .read   = bin_attr_nvmem_read,
        .write  = bin_attr_nvmem_write,
@@ -225,7 +225,7 @@ static const struct attribute_group *nvmem_rw_root_dev_groups[] = {
 static struct bin_attribute bin_attr_ro_root_nvmem = {
        .attr   = {
                .name   = "nvmem",
-               .mode   = S_IRUSR,
+               .mode   = 0400,
        },
        .read   = bin_attr_nvmem_read,
 };