]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
perf tools: Get rid of dso__data_fd() from dso__data_size()
authorNamhyung Kim <namhyung@kernel.org>
Wed, 20 May 2015 16:03:40 +0000 (01:03 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 27 May 2015 15:21:44 +0000 (12:21 -0300)
It seems that the dso__data_fd() was needed to find a binary type
since open in data_file_size() alone used to fail.

But as it can open the dso fine now, the dso__data_fd() can go away.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1432137821-10853-2-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/dso.c

index 516e0c25ea16724ca896f5dec0a7442f42717e8c..e95e850dd832682409e62016797e8087d01ce0ae 100644 (file)
@@ -745,12 +745,6 @@ out:
  */
 off_t dso__data_size(struct dso *dso, struct machine *machine)
 {
-       int fd;
-
-       fd = dso__data_fd(dso, machine);
-       if (fd < 0)
-               return fd;
-
        if (data_file_size(dso, machine))
                return -1;