]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
selftests: set conf.all.rp_filter=0 in bareudp.sh
authorGuillaume Nault <gnault@redhat.com>
Wed, 11 Nov 2020 15:05:35 +0000 (16:05 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 13 Nov 2020 00:14:38 +0000 (16:14 -0800)
When working on the rp_filter problem, I didn't realise that disabling
it on the network devices didn't cover all cases: rp_filter could also
be enabled globally in the namespace, in which case it would drop
packets, even if the net device has rp_filter=0.

Fixes: 1ccd58331f6f ("selftests: disable rp_filter when testing bareudp")
Fixes: bbbc7aa45eef ("selftests: add test script for bareudp tunnels")
Signed-off-by: Guillaume Nault <gnault@redhat.com>
Link: https://lore.kernel.org/r/f2d459346471f163b239aa9d63ce3e2ba9c62895.1605107012.git.gnault@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/bareudp.sh

index c2b9e990e54428393716c2ac092903afb27dc479..f366cadbc5e862a586f30abee6223a1be44b33d7 100755 (executable)
@@ -238,6 +238,8 @@ setup_overlay_ipv4()
        # The intermediate namespaces don't have routes for the reverse path,
        # as it will be handled by tc. So we need to ensure that rp_filter is
        # not going to block the traffic.
+       ip netns exec "${NS1}" sysctl -qw net.ipv4.conf.all.rp_filter=0
+       ip netns exec "${NS2}" sysctl -qw net.ipv4.conf.all.rp_filter=0
        ip netns exec "${NS1}" sysctl -qw net.ipv4.conf.default.rp_filter=0
        ip netns exec "${NS2}" sysctl -qw net.ipv4.conf.default.rp_filter=0
 }