zebra: fix for issues found during static analysis

This patch addresses fix for issues found during static analysis.
rt_netlink - initialise vtep if there is NDA_DST attribute
if_netlink - initialise vni_start and vni_end

Signed-off-by: Sharath Ramamurthy <sramamurthy@nvidia.com>

diff --git a/zebra/if_netlink.c b/zebra/if_netlink.c
index c097e237777f6fcf13bd8c2488edad22b2b47d92..02b9ab9d7f6186c2c250250c2312c0939e491f18 100644 (file)
--- a/zebra/if_netlink.c
+++ b/zebra/if_netlink.c
@@ -737,6 +737,9 @@ static int netlink_bridge_vxlan_vlan_vni_map_update(struct interface *ifp,
        struct zebra_vxlan_vni vni_start;
        struct rtattr *aftb[IFLA_BRIDGE_VLAN_TUNNEL_MAX + 1];
 
+       memset(&vni_start, 0, sizeof(vni_start));
+       memset(&vni_end, 0, sizeof(vni_end));
+
        for (i = RTA_DATA(af_spec), rem = RTA_PAYLOAD(af_spec); RTA_OK(i, rem);
             i = RTA_NEXT(i, rem)) {
 

diff --git a/zebra/rt_netlink.c b/zebra/rt_netlink.c
index f205f297db17595b612868b6bfbab6f0126e345b..d09318a5a52a5b69dd86b4a1e5262025ccb03d23 100644 (file)
--- a/zebra/rt_netlink.c
+++ b/zebra/rt_netlink.c
@@ -3536,7 +3536,8 @@ static int netlink_macfdb_change(struct nlmsghdr *h, int len, ns_id_t ns_id)
                       IPV4_MAX_BYTELEN);
                snprintfrr(dst_buf, sizeof(dst_buf), " dst %pI4",
                           &vtep_ip);
-       }
+       } else
+               memset(&vtep_ip, 0, sizeof(vtep_ip));
 
        if (tb[NDA_NH_ID])
                nhg_id = *(uint32_t *)RTA_DATA(tb[NDA_NH_ID]);