]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
sched/debug: Remove mpol_get/put and task_lock/unlock from sched_show_numa
authorBharata B Rao <bharata@amd.com>
Tue, 18 Jan 2022 05:05:15 +0000 (10:35 +0530)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 12:38:05 +0000 (14:38 +0200)
BugLink: https://bugs.launchpad.net/bugs/1969110
[ Upstream commit 28c988c3ec29db74a1dda631b18785958d57df4f ]

The older format of /proc/pid/sched printed home node info which
required the mempolicy and task lock around mpol_get(). However
the format has changed since then and there is no need for
sched_show_numa() any more to have mempolicy argument,
asssociated mpol_get/put and task_lock/unlock. Remove them.

Fixes: 397f2378f1361 ("sched/numa: Fix numa balancing stats in /proc/pid/sched")
Signed-off-by: Bharata B Rao <bharata@amd.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Acked-by: Mel Gorman <mgorman@suse.de>
Link: https://lore.kernel.org/r/20220118050515.2973-1-bharata@amd.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 8bc68c44d97f28978aaa0012c395dc6f08dc02c3)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
kernel/sched/debug.c

index 17a653b67006af6fed33ceae0ee3608d8e8eb0ad..7a2d32d2025fe29c9940752ae5dceb8f922745b1 100644 (file)
@@ -921,25 +921,15 @@ void print_numa_stats(struct seq_file *m, int node, unsigned long tsf,
 static void sched_show_numa(struct task_struct *p, struct seq_file *m)
 {
 #ifdef CONFIG_NUMA_BALANCING
-       struct mempolicy *pol;
-
        if (p->mm)
                P(mm->numa_scan_seq);
 
-       task_lock(p);
-       pol = p->mempolicy;
-       if (pol && !(pol->flags & MPOL_F_MORON))
-               pol = NULL;
-       mpol_get(pol);
-       task_unlock(p);
-
        P(numa_pages_migrated);
        P(numa_preferred_nid);
        P(total_numa_faults);
        SEQ_printf(m, "current_node=%d, numa_group_id=%d\n",
                        task_node(p), task_numa_group_id(p));
        show_numa_stats(p, m);
-       mpol_put(pol);
 #endif
 }