]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
drm/udl: Deletion of an unnecessary check before the function call "vunmap"
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 19 Nov 2014 16:33:32 +0000 (17:33 +0100)
committerDave Airlie <airlied@redhat.com>
Fri, 21 Nov 2014 02:16:35 +0000 (12:16 +1000)
The vunmap() function performes also input parameter validation. Thus the test
around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/udl/udl_gem.c

index 692d6f21f1bc17ffd6114a8d79db7af49199f701..cd3482de5cab4e1de1c86a2b4f49660a7a689745 100644 (file)
@@ -184,8 +184,7 @@ void udl_gem_vunmap(struct udl_gem_object *obj)
                return;
        }
 
-       if (obj->vmapping)
-               vunmap(obj->vmapping);
+       vunmap(obj->vmapping);
 
        udl_gem_put_pages(obj);
 }