jslint: type confusion

fix many type confusions

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>

diff --git a/js/ActionList.js b/js/ActionList.js
index 06288bd707b4c1e93ac33e8f8e72412bf5b998f7..0d08bc93046dca21d5704300cd012cfc9657170a 100644 (file)
--- a/js/ActionList.js
+++ b/js/ActionList.js
@@ -82,7 +82,10 @@ Ext.define('PMG.ActionList', {
 
            var config = Ext.apply({ method: 'POST' }, editor);
 
-           config.create = true,
+           /*jslint confusion: true*/
+           /*create is a boolean below and a function above*/
+           config.create = true;
+           /*jslint confusion: false*/
            menu_items.push({
                text: config.subject,
                handler: function() {

diff --git a/js/FilterProxy.js b/js/FilterProxy.js
index be1d91986aa3541ac4dacdefa0b100cf0481d6a2..360ac6771efb7ccb7982b67e56d6775b74882de5 100644 (file)
--- a/js/FilterProxy.js
+++ b/js/FilterProxy.js
@@ -13,11 +13,13 @@ Ext.define('PMG.FilterProxy', {
 
        var filters = operation.getFilters() || [];
        for (i = 0; i < filters.length; i++) {
-           filter = filters[i];
+           var filter = filters[i];
            if (filter.config.id === me.filterId) {
                var v = filter.getValue();
                if (v !== undefined && v !== '') {
+                   /*jslint confusion: true */
                    params.filter = v;
+                   /*jslint confusion: false */
                }
            }
        }

diff --git a/js/LDAPGroupEditor.js b/js/LDAPGroupEditor.js
index e05980a84152be0375a7bf285825a8e53da4ee17..4280a41c1cbfd302ba90b4197365acd7ab8c90e3 100644 (file)
--- a/js/LDAPGroupEditor.js
+++ b/js/LDAPGroupEditor.js
@@ -97,5 +97,5 @@ Ext.define('PMG.LDAPGroupEditor', {
 
     width: 500,
 
-    items: { xtype: 'pmgLDAPGroupInputPanel' }
+    items: [{ xtype: 'pmgLDAPGroupInputPanel' }]
 });

diff --git a/js/LDAPUserEditor.js b/js/LDAPUserEditor.js
index f7db13a56f1178288a3b9852b4a637c589b80e94..1fcaf8fc171c7104a1dac4ac051be4b3cf9d040a 100644 (file)
--- a/js/LDAPUserEditor.js
+++ b/js/LDAPUserEditor.js
@@ -51,5 +51,5 @@ Ext.define('PMG.LDAPUserEditor', {
 
     width: 500,
 
-    items: { xtype: 'pmgLDAPUserInputPanel' }
+    items: [{ xtype: 'pmgLDAPUserInputPanel' }]
 });

diff --git a/js/LoginView.js b/js/LoginView.js
index fb2673ec4874cf780446ac8ceb82ade1de68ca8d..ed8997f0e622289905b45f84f1fcfbd5ae7dc8ed 100644 (file)
--- a/js/LoginView.js
+++ b/js/LoginView.js
@@ -87,7 +87,9 @@ Ext.define('PMG.LoginView', {
 
     plugins: 'viewport',
 
-    layout: 'border',
+    layout: {
+       type: 'border'
+    },
 
     items: [
        {
@@ -121,14 +123,18 @@ Ext.define('PMG.LoginView', {
 
            defaultFocus: 'usernameField',
 
-           layout: 'auto',
+           layout: {
+               type: 'auto'
+           },
 
            title: gettext('Proxmox Mail Gateway Login'),
 
            items: [
                {
                    xtype: 'form',
-                   layout: 'form',
+                   layout: {
+                       type: 'form'
+                   },
                    defaultButton: 'loginButton',
                    url: '/api2/extjs/access/ticket',
                    reference: 'loginForm',

diff --git a/js/MainView.js b/js/MainView.js
index cde48309a675c36898298a40cfb2ad64aecb18a7..e537db20f9031f3cc3d0fc5d52502f982360de4c 100644 (file)
--- a/js/MainView.js
+++ b/js/MainView.js
@@ -87,7 +87,10 @@ Ext.define('PMG.MainView', {
        logout: function() {
            var me = this;
            Proxmox.Utils.authClear();
+           /*jslint confusion: true*/
+           /*destroy is a function below and boolean above */
            me.getView().destroy();
+           /*jslint confusion: false*/
            Ext.create({ xtype: 'loginview'});
        },
 
@@ -155,7 +158,7 @@ Ext.define('PMG.MainView', {
 
     plugins: 'viewport',
 
-    layout: 'border',
+    layout: { type: 'border' },
 
     items: [
        {
@@ -225,7 +228,7 @@ Ext.define('PMG.MainView', {
        },
        {
            xtype: 'panel',
-           layout: 'card',
+           layout: { type: 'card' },
            region: 'center',
            border: false,
            reference: 'contentpanel'

diff --git a/js/ObjectGroupList.js b/js/ObjectGroupList.js
index 6d328828cf199a731c32122545557f7aa70e1a88..75b8f9679feebc3d6f2abcf6b6532fa34e4a7b83 100644 (file)
--- a/js/ObjectGroupList.js
+++ b/js/ObjectGroupList.js
@@ -102,6 +102,8 @@ Ext.define('PMG.ObjectGroupList', {
            waitMsgTarget: me
        });
 
+       /*jslint confusion: true*/
+       /* create is a boolean below, a function above */
        var tbar = [
             {
                xtype: 'proxmoxButton',
@@ -130,6 +132,7 @@ Ext.define('PMG.ObjectGroupList', {
             },
            remove_btn
         ];
+       /*jslint confusion: false*/
 
        Proxmox.Utils.monStoreErrors(me, me.store);
 

diff --git a/js/RuleInfo.js b/js/RuleInfo.js
index ac81062cf42e90cdc79eb4e9d2f0a86acef1adb5..621ebfb81e2a826b5d4af47c9e5ecd9c64974d25 100644 (file)
--- a/js/RuleInfo.js
+++ b/js/RuleInfo.js
@@ -1,4 +1,6 @@
 /*global Proxmox*/
+/*jslint confusion: true*/
+/* bind is a function function */
 Ext.define('PMG.RuleInfo', {
     extend: 'Ext.panel.Panel',
     xtype: 'pmgRuleInfo',
@@ -233,9 +235,9 @@ Ext.define('PMG.RuleInfo', {
     items: [
        {
            xtype: 'panel',
-           bodyPadding: 10,
+           bodyPadding: '10 10 10 10',
            data: {
-               name: false,
+               name: ''
            },
            bind: {
                data: {

diff --git a/js/SpamQuarantine.js b/js/SpamQuarantine.js
index ab8ac0926e5f5c33ea7f580f146c64504a218948..7d5775409444c12b3fb321992c28023b89265246 100644 (file)
--- a/js/SpamQuarantine.js
+++ b/js/SpamQuarantine.js
@@ -1,4 +1,6 @@
 /*global Proxmox*/
+/*jslint confusion: true*/
+/*format is a string and a function*/
 Ext.define('pmg-spam-archive', {
     extend: 'Ext.data.Model',
     fields: [
@@ -144,7 +146,7 @@ Ext.define('PMG.SpamQuarantine', {
     xtype: 'pmgSpamQuarantine',
 
     border: false,
-    layout: 'border',
+    layout: { type: 'border' },
 
     defaults: { border: false },
 
@@ -365,7 +367,7 @@ Ext.define('PMG.SpamQuarantine', {
        },
        {
            title: gettext('Selected Mail'),
-           border: 0,
+           border: false,
            region: 'center',
            split: true,
            reference: 'preview',