drm/i915/cmdparser: Fix jump whitelist clearing

When a jump_whitelist bitmap is reused, it needs to be cleared.
Currently this is done with memset() and the size calculation assumes
bitmaps are made of 32-bit words, not longs.  So on 64-bit
architectures, only the first half of the bitmap is cleared.

If some whitelist bits are carried over between successive batches
submitted on the same context, this will presumably allow embedding
the rogue instructions that we're trying to reject.

Use bitmap_zero() instead, which gets the calculation right.

Fixes: f8c08d8faee5 ("drm/i915/cmdparser: Add support for backward jumps")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Jon Bloomfield <jon.bloomfield@intel.com>

diff --git a/drivers/gpu/drm/i915/i915_cmd_parser.c b/drivers/gpu/drm/i915/i915_cmd_parser.c
index d78debed06e2f1f60d1dcbda81b954e95ceccdeb..f24096e27bef436a31ea26af854705505cebdaa7 100644 (file)
--- a/drivers/gpu/drm/i915/i915_cmd_parser.c
+++ b/drivers/gpu/drm/i915/i915_cmd_parser.c
@@ -1375,7 +1375,7 @@ static void init_whitelist(struct i915_gem_context *ctx, u32 batch_len)
                return;
 
        if (batch_cmds <= ctx->jump_whitelist_cmds) {
-               memset(ctx->jump_whitelist, 0, exact_size * sizeof(u32));
+               bitmap_zero(ctx->jump_whitelist, batch_cmds);
                return;
        }
 
@@ -1395,8 +1395,7 @@ again:
        }
 
        DRM_DEBUG("CMD: Failed to extend whitelist. BB_START may be disallowed\n");
-       memset(ctx->jump_whitelist, 0,
-              BITS_TO_LONGS(ctx->jump_whitelist_cmds) * sizeof(u32));
+       bitmap_zero(ctx->jump_whitelist, ctx->jump_whitelist_cmds);
 
        return;
 }