]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
net: mvmdio: print warning when orion-mdio has too many clocks
authorJosua Mayer <josua@solid-run.com>
Tue, 9 Jul 2019 13:01:00 +0000 (15:01 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 9 Jul 2019 20:03:04 +0000 (13:03 -0700)
Print a warning when device tree specifies more than the maximum of four
clocks supported by orion-mdio. Because reading from mdio can lock up
the Armada 8k when a required clock is not initialized, it is important
to notify the user when a specified clock is ignored.

Signed-off-by: Josua Mayer <josua@solid-run.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvmdio.c

index e17d563e97a6b7f37cdefa77e795aea2234e30f3..eba18065a4dafad2deffd513af3fc12c02ebf04e 100644 (file)
@@ -326,6 +326,10 @@ static int orion_mdio_probe(struct platform_device *pdev)
                clk_prepare_enable(dev->clk[i]);
        }
 
+       if (!IS_ERR(of_clk_get(pdev->dev.of_node, ARRAY_SIZE(dev->clk))))
+               dev_warn(&pdev->dev, "unsupported number of clocks, limiting to the first "
+                        __stringify(ARRAY_SIZE(dev->clk)) "\n");
+
        dev->err_interrupt = platform_get_irq(pdev, 0);
        if (dev->err_interrupt > 0 &&
            resource_size(r) < MVMDIO_ERR_INT_MASK + 4) {