]> git.proxmox.com Git - pve-manager.git/commitdiff
ui: vm opts: clarify QGA option
authorThomas Lamprecht <t.lamprecht@proxmox.com>
Thu, 10 Oct 2019 09:53:36 +0000 (11:53 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Thu, 10 Oct 2019 15:50:23 +0000 (17:50 +0200)
To make it more clear that PVE does not somehow magically injects a
QHA into the VM, but that this can be set if one has installed the
QGA in the VM themself.

So slightly adapt the label by prepending "Use" and adding a hint for
further details.

Also ensure we call it the real name everywhere, i.e., "QEMU Guest
Agent", this makes it a bit more consistent and easier to find
information for users.

Suggested-by: Aaron Lauterer <t.lamprecht@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
www/manager6/form/AgentFeatureSelector.js
www/manager6/qemu/Options.js

index d50b709e03382e933890dba201b29b8706a35d48..44ef2e577306fb2de81d0cd49965fef82b509378 100644 (file)
@@ -7,7 +7,7 @@ Ext.define('PVE.form.AgentFeatureSelector', {
     items: [
        {
            xtype: 'proxmoxcheckbox',
-           boxLabel: gettext('Qemu Agent'),
+           boxLabel: Ext.String.format(gettext('Use {0}'), 'QEMU Guest Agent'),
            name: 'enabled',
            reference: 'enabled',
            uncheckedValue: 0,
@@ -20,7 +20,15 @@ Ext.define('PVE.form.AgentFeatureSelector', {
                disabled: '{!enabled.checked}',
            },
            disabled: true
-       }
+       },
+       {
+           xtype: 'displayfield',
+           userCls: 'pmx-hint',
+           value: gettext('Make sure the QEMU Guest Agent is installed in the VM'),
+           bind: {
+               hidden: '{!enabled.checked}',
+           },
+       },
     ],
 
     onGetValues: function(values) {
@@ -29,8 +37,7 @@ Ext.define('PVE.form.AgentFeatureSelector', {
     },
 
     setValues: function(values) {
-       var agent = values.agent || '';
-       var res = PVE.Parser.parsePropertyString(agent, 'enabled');
+       let res = PVE.Parser.parsePropertyString(values.agent, 'enabled');
        this.callParent([res]);
     }
 });
index 4a8e06e9481cbe245d42b400efe6019a6479aaf2..1545e1c81cb9f7c710b941df215da863eb469c14 100644 (file)
@@ -252,12 +252,13 @@ Ext.define('PVE.qemu.Options', {
                editor: caps.vms['VM.Config.HWType'] ? 'PVE.qemu.Smbios1Edit' : undefined
            },
            agent: {
-               header: gettext('Qemu Agent'),
+               header: 'QEMU Guest Agent',
                defaultValue: false,
                renderer: PVE.Utils.render_qga_features,
                editor: caps.vms['VM.Config.Options'] ? {
                    xtype: 'proxmoxWindowEdit',
                    subject: gettext('Qemu Agent'),
+                   width: 350,
                    items: {
                        xtype: 'pveAgentFeatureSelector',
                        name: 'agent'