]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
kernel/fail_function.c: remove meaningless null pointer check before debugfs_remove_r...
authorzhong jiang <zhongjiang@huawei.com>
Tue, 30 Oct 2018 22:04:51 +0000 (15:04 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 31 Oct 2018 15:54:12 +0000 (08:54 -0700)
debugfs_remove_recursive() has taken the null pointer into account.  just
remove the null check before debugfs_remove_recursive().

Link: http://lkml.kernel.org/r/1537494404-16473-1-git-send-email-zhongjiang@huawei.com
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Acked-by: Kees Cook <keescook@chromium.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/fail_function.c

index bc80a4e268c0bc27132ecb782df98276b282b237..17f75b545f665c6df331c88ee5d6b6e19112ddb6 100644 (file)
@@ -173,8 +173,7 @@ static void fei_debugfs_remove_attr(struct fei_attr *attr)
        struct dentry *dir;
 
        dir = debugfs_lookup(attr->kp.symbol_name, fei_debugfs_dir);
-       if (dir)
-               debugfs_remove_recursive(dir);
+       debugfs_remove_recursive(dir);
 }
 
 static int fei_kprobe_handler(struct kprobe *kp, struct pt_regs *regs)