]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
perf report: Improve error msg when no first/last sample time found
authorJin Yao <yao.jin@linux.intel.com>
Wed, 10 Jan 2018 15:00:26 +0000 (23:00 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 17 Jan 2018 13:23:34 +0000 (10:23 -0300)
The following message will be returned to user when executing
'perf report --time' if perf data file doesn't contain the
first/last sample time.

"HINT: no first/last sample time found in perf data.
 Please use latest perf binary to execute 'perf record'
 (if '--buildid-all' is enabled, needs to set '--timestamp-boundary')."

Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
Reviewed-by: Jiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1515596433-24653-2-git-send-email-yao.jin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-report.c

index 6593779224d5c763e5e22934c22f9355b6ed1354..7d4f0a5de326156cae7ba4511120a6c884dc9715 100644 (file)
@@ -1300,7 +1300,9 @@ repeat:
        if (perf_time__parse_str(report.ptime_range, report.time_str) != 0) {
                if (session->evlist->first_sample_time == 0 &&
                    session->evlist->last_sample_time == 0) {
-                       pr_err("No first/last sample time in perf data\n");
+                       pr_err("HINT: no first/last sample time found in perf data.\n"
+                              "Please use latest perf binary to execute 'perf record'\n"
+                              "(if '--buildid-all' is enabled, please set '--timestamp-boundary').\n");
                        return -EINVAL;
                }