]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
drm/amdgpu: add one definition for RAS's sysfs/debugfs name(v2)
authorGuchun Chen <guchun.chen@amd.com>
Fri, 31 Jul 2020 06:39:57 +0000 (14:39 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 4 Aug 2020 21:27:08 +0000 (17:27 -0400)
Add one definition for the RAS module's FS name. It's used
in both debugfs and sysfs cases.

v2: Use static variable instead of macro definition.

Signed-off-by: Guchun Chen <guchun.chen@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

index 19ac2e6ad60e1b1e6d7d5c304e55b9e0ef617e8c..08869e4a5374c6f238a52d41d13b30d3bbe6ddc1 100644 (file)
@@ -34,6 +34,8 @@
 #include "amdgpu_xgmi.h"
 #include "ivsrcid/nbio/irqsrcs_nbif_7_4.h"
 
+static const char *RAS_FS_NAME = "ras";
+
 const char *ras_error_string[] = {
        "none",
        "parity",
@@ -1037,7 +1039,7 @@ static int amdgpu_ras_sysfs_create_feature_node(struct amdgpu_device *adev)
                NULL
        };
        struct attribute_group group = {
-               .name = "ras",
+               .name = RAS_FS_NAME,
                .attrs = attrs,
                .bin_attrs = bin_attrs,
        };
@@ -1078,7 +1080,7 @@ static int amdgpu_ras_sysfs_remove_feature_node(struct amdgpu_device *adev)
                NULL
        };
        struct attribute_group group = {
-               .name = "ras",
+               .name = RAS_FS_NAME,
                .attrs = attrs,
                .bin_attrs = bin_attrs,
        };
@@ -1113,7 +1115,7 @@ int amdgpu_ras_sysfs_create(struct amdgpu_device *adev,
 
        if (sysfs_add_file_to_group(&adev->dev->kobj,
                                &obj->sysfs_attr.attr,
-                               "ras")) {
+                               RAS_FS_NAME)) {
                put_obj(obj);
                return -EINVAL;
        }
@@ -1133,7 +1135,7 @@ int amdgpu_ras_sysfs_remove(struct amdgpu_device *adev,
 
        sysfs_remove_file_from_group(&adev->dev->kobj,
                                &obj->sysfs_attr.attr,
-                               "ras");
+                               RAS_FS_NAME);
        obj->attr_inuse = 0;
        put_obj(obj);
 
@@ -1179,7 +1181,7 @@ static void amdgpu_ras_debugfs_create_ctrl_node(struct amdgpu_device *adev)
        struct amdgpu_ras *con = amdgpu_ras_get_context(adev);
        struct drm_minor *minor = adev->ddev->primary;
 
-       con->dir = debugfs_create_dir("ras", minor->debugfs_root);
+       con->dir = debugfs_create_dir(RAS_FS_NAME, minor->debugfs_root);
        debugfs_create_file("ras_ctrl", S_IWUGO | S_IRUGO, con->dir,
                                adev, &amdgpu_ras_debugfs_ctrl_ops);
        debugfs_create_file("ras_eeprom_reset", S_IWUGO | S_IRUGO, con->dir,