]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
net: b44: use true,false for bool variables
authorJason Yan <yanaijie@huawei.com>
Sat, 19 Sep 2020 07:45:27 +0000 (15:45 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 19 Sep 2020 21:23:13 +0000 (14:23 -0700)
This addresses the following coccinelle warning:

drivers/net/ethernet/broadcom/b44.c:2213:6-20: WARNING: Assignment of
0/1 to bool variable
drivers/net/ethernet/broadcom/b44.c:2218:2-16: WARNING: Assignment of
0/1 to bool variable
drivers/net/ethernet/broadcom/b44.c:2226:3-17: WARNING: Assignment of
0/1 to bool variable
drivers/net/ethernet/broadcom/b44.c:2230:3-17: WARNING: Assignment of
0/1 to bool variable

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/b44.c

index 6fb620e2520874a05d8112e270a58cb07cdfdbd8..74c1778d841ea1cf1b8b9a978890bd859293c36b 100644 (file)
@@ -2210,12 +2210,12 @@ static void b44_adjust_link(struct net_device *dev)
 {
        struct b44 *bp = netdev_priv(dev);
        struct phy_device *phydev = dev->phydev;
-       bool status_changed = 0;
+       bool status_changed = false;
 
        BUG_ON(!phydev);
 
        if (bp->old_link != phydev->link) {
-               status_changed = 1;
+               status_changed = true;
                bp->old_link = phydev->link;
        }
 
@@ -2223,11 +2223,11 @@ static void b44_adjust_link(struct net_device *dev)
        if (phydev->link) {
                if ((phydev->duplex == DUPLEX_HALF) &&
                    (bp->flags & B44_FLAG_FULL_DUPLEX)) {
-                       status_changed = 1;
+                       status_changed = true;
                        bp->flags &= ~B44_FLAG_FULL_DUPLEX;
                } else if ((phydev->duplex == DUPLEX_FULL) &&
                           !(bp->flags & B44_FLAG_FULL_DUPLEX)) {
-                       status_changed = 1;
+                       status_changed = true;
                        bp->flags |= B44_FLAG_FULL_DUPLEX;
                }
        }