]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
bpf: Fix build failure for kernel/trace/bpf_trace.c with CONFIG_NET=n
authorYonghong Song <yhs@fb.com>
Wed, 7 Oct 2020 06:29:33 +0000 (23:29 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 7 Oct 2020 17:56:46 +0000 (10:56 -0700)
When CONFIG_NET is not defined, I hit the following build error:
    kernel/trace/bpf_trace.o:(.rodata+0x110): undefined reference to `bpf_prog_test_run_raw_tp'

Commit 1b4d60ec162f ("bpf: Enable BPF_PROG_TEST_RUN for raw_tracepoint")
added test_run support for raw_tracepoint in /kernel/trace/bpf_trace.c.
But the test_run function bpf_prog_test_run_raw_tp is defined in
net/bpf/test_run.c, only available with CONFIG_NET=y.

Adding a CONFIG_NET guard for
    .test_run = bpf_prog_test_run_raw_tp;
fixed the above build issue.

Fixes: 1b4d60ec162f ("bpf: Enable BPF_PROG_TEST_RUN for raw_tracepoint")
Signed-off-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20201007062933.3425899-1-yhs@fb.com
kernel/trace/bpf_trace.c

index a136a6a63a7190842a65ab9d04e05af9b6be72be..a2a4535b62774600dfb126174ca3fa213d2169f1 100644 (file)
@@ -1780,7 +1780,9 @@ const struct bpf_verifier_ops raw_tracepoint_verifier_ops = {
 };
 
 const struct bpf_prog_ops raw_tracepoint_prog_ops = {
+#ifdef CONFIG_NET
        .test_run = bpf_prog_test_run_raw_tp,
+#endif
 };
 
 const struct bpf_verifier_ops tracing_verifier_ops = {