]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
mmc: dw_mmc: Remove prev_state and state assignment for STATE_SENDING_CMD
authorShawn Lin <shawn.lin@rock-chips.com>
Fri, 23 Feb 2018 02:23:16 +0000 (10:23 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 5 Mar 2018 12:04:29 +0000 (13:04 +0100)
Clang reports a compile warning:
drivers/mmc/host/dw_mmc.c:2124:5: warning: Value stored to 'prev_state'
is never read

By checking the code, prev_state and state assignment for
STATE_SENDING_CMD is indeed never used after jumping to unlock tag.
So remove it.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/dw_mmc.c

index 5332120030e421f8aad2c0fcfe99d96cfc1371b1..aecc3e255507dc24b784e808871addf65d0a3d3b 100644 (file)
@@ -2001,7 +2001,6 @@ static void dw_mci_tasklet_func(unsigned long priv)
                        set_bit(EVENT_CMD_COMPLETE, &host->completed_events);
                        err = dw_mci_command_complete(host, cmd);
                        if (cmd == mrq->sbc && !err) {
-                               prev_state = state = STATE_SENDING_CMD;
                                __dw_mci_start_request(host, host->slot,
                                                       mrq->cmd);
                                goto unlock;