]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
mm/damon/lru_sort: fix potential memory leak in damon_lru_sort_init()
authorSeongJae Park <sj@kernel.org>
Thu, 14 Jul 2022 17:04:58 +0000 (17:04 +0000)
committerakpm <akpm@linux-foundation.org>
Mon, 18 Jul 2022 00:14:27 +0000 (17:14 -0700)
damon_lru_sort_init() returns an error when damon_select_ops() fails
without freeing 'ctx' which allocated before.  This commit fixes the
potential memory leak by freeing 'ctx' under the situation.

Link: https://lkml.kernel.org/r/20220714170458.49727-1-sj@kernel.org
Fixes: 40e983cca927 ("mm/damon: introduce DAMON-based LRU-lists Sorting")
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/lru_sort.c

index c276736a071c4994bb4ab8f2fab9457bed37de8b..9de6f00a71c5dd8165ddf7249867caddaadfd34f 100644 (file)
@@ -524,8 +524,10 @@ static int __init damon_lru_sort_init(void)
        if (!ctx)
                return -ENOMEM;
 
-       if (damon_select_ops(ctx, DAMON_OPS_PADDR))
+       if (damon_select_ops(ctx, DAMON_OPS_PADDR)) {
+               damon_destroy_ctx(ctx);
                return -EINVAL;
+       }
 
        ctx->callback.after_wmarks_check = damon_lru_sort_after_wmarks_check;
        ctx->callback.after_aggregation = damon_lru_sort_after_aggregation;