test_helpers: do not rely on assert

The functions loose_object_mode and loose_object_dir_mode call stat
inside an assert statement which isn't evaluated when compiling in
Release mode (NDEBUG) and leads to failing tests. Replace it.

Signed-off-by: schu <schu-github@schulog.org>

diff --git a/tests/test_helpers.c b/tests/test_helpers.c
index 47a0b1b11dbf5e643323855faa64ab765bfa4066..31e38bf6a6d3be09b7733caf3f8857b85b020a18 100644 (file)
--- a/tests/test_helpers.c
+++ b/tests/test_helpers.c
@@ -116,7 +116,8 @@ int loose_object_mode(const char *repository_folder, git_object *object)
        struct stat st;
 
        locate_loose_object(repository_folder, object, &object_path, NULL);
-       assert(p_stat(object_path, &st) == 0);
+       if (p_stat(object_path, &st) < 0)
+               return 0;
        free(object_path);
 
        return st.st_mode;
@@ -138,7 +139,8 @@ int loose_object_dir_mode(const char *repository_folder, git_object *object)
                }
        }
 
-       assert(p_stat(object_path, &st) == 0);
+       if (p_stat(object_path, &st) < 0)
+               return 0;
        free(object_path);
 
        return st.st_mode;