]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
[media] m88ds3103: fix undefined division
authorPeter Rosin <peda@axentia.se>
Wed, 16 Mar 2016 12:14:13 +0000 (09:14 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 13 Apr 2016 22:17:39 +0000 (19:17 -0300)
s32tmp in the below code may be negative, and dev->mclk_khz is an
unsigned type.

s32tmp = 0x10000 * (tuner_frequency - c->frequency);
s32tmp = DIV_ROUND_CLOSEST(s32tmp, dev->mclk_khz);

This is undefined, as DIV_ROUND_CLOSEST is undefined for negative
dividends when the divisor is of unsigned type.

So, change mclk_khz to be signed (s32).

Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/dvb-frontends/m88ds3103_priv.h

index eee8c22c51ec507da592ecff92c9f2f574159dc9..651e005146b21546848ce324a386dfa0851e5499 100644 (file)
@@ -46,7 +46,7 @@ struct m88ds3103_dev {
        /* auto detect chip id to do different config */
        u8 chip_id;
        /* main mclk is calculated for M88RS6000 dynamically */
-       u32 mclk_khz;
+       s32 mclk_khz;
        u64 post_bit_error;
        u64 post_bit_count;
 };