]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
team: forbid incorrect fall-through in notifier
authorJiri Pirko <jiri@resnulli.us>
Wed, 23 Apr 2014 12:17:55 +0000 (14:17 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 24 Apr 2014 17:26:32 +0000 (13:26 -0400)
There are two breaks missing there. The result is that userspace
receives multiple messages which might be confusing.

Introduced-by: 3d249d4c "net: introduce ethernet teaming device"
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/team/team.c

index 33008c1d1d678756ae8fbae13238763c24cc603e..767fe61b5ac995323fa4d3e2d1b2d7ac3869ec00 100644 (file)
@@ -2834,8 +2834,10 @@ static int team_device_event(struct notifier_block *unused,
        case NETDEV_UP:
                if (netif_carrier_ok(dev))
                        team_port_change_check(port, true);
+               break;
        case NETDEV_DOWN:
                team_port_change_check(port, false);
+               break;
        case NETDEV_CHANGE:
                if (netif_running(port->dev))
                        team_port_change_check(port,