]> git.proxmox.com Git - mirror_qemu.git/commitdiff
target-arm: Fix TCG temp handling in 64 bit cp writes
authorPeter Maydell <peter.maydell@linaro.org>
Thu, 12 Jul 2012 10:59:04 +0000 (10:59 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Thu, 12 Jul 2012 10:59:53 +0000 (10:59 +0000)
Fix errors in the TCG temp handling in the 64 bit coprocessor
write path: we were reusing a 32 bit temp after it had been
freed by store_reg(), and failing to free a 64 bit temp.

This bug has no visible effect at this point because there
aren't any non-NOP 64 bit registers yet; it needs to be fixed
as a prerequisite for the 64 bit registers in LPAE support.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
target-arm/translate.c

index f39b9caa28bcac4df0613a9ec5eee84e38272fae..29008a4b3460a3458afb01033e52e8c56e147f29 100644 (file)
@@ -6263,7 +6263,9 @@ static int disas_coproc_insn(CPUARMState * env, DisasContext *s, uint32_t insn)
                 tcg_gen_trunc_i64_i32(tmp, tmp64);
                 store_reg(s, rt, tmp);
                 tcg_gen_shri_i64(tmp64, tmp64, 32);
+                tmp = tcg_temp_new_i32();
                 tcg_gen_trunc_i64_i32(tmp, tmp64);
+                tcg_temp_free_i64(tmp64);
                 store_reg(s, rt2, tmp);
             } else {
                 TCGv tmp;