]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
uprobes/x86: Use existing definitions for segment override prefixes
authorRicardo Neri <ricardo.neri-calderon@linux.intel.com>
Fri, 27 Oct 2017 20:25:31 +0000 (13:25 -0700)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 1 Nov 2017 20:50:08 +0000 (21:50 +0100)
Rather than using hard-coded values of the segment override prefixes,
leverage the existing definitions provided in inat.h.

Suggested-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Borislav Petkov <bp@suse.de>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: ricardo.neri@intel.com
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: "Ravi V. Shankar" <ravi.v.shankar@intel.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Chris Metcalf <cmetcalf@mellanox.com>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Chen Yucong <slaoub@gmail.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: https://lkml.kernel.org/r/1509135945-13762-5-git-send-email-ricardo.neri-calderon@linux.intel.com
arch/x86/kernel/uprobes.c

index 495c776de4b470f8eb53236a0ddeb2ca8f043b6b..a3755d293a48ca038844ed92e15ea071efdd6449 100644 (file)
@@ -271,12 +271,15 @@ static bool is_prefix_bad(struct insn *insn)
        int i;
 
        for (i = 0; i < insn->prefixes.nbytes; i++) {
-               switch (insn->prefixes.bytes[i]) {
-               case 0x26:      /* INAT_PFX_ES   */
-               case 0x2E:      /* INAT_PFX_CS   */
-               case 0x36:      /* INAT_PFX_DS   */
-               case 0x3E:      /* INAT_PFX_SS   */
-               case 0xF0:      /* INAT_PFX_LOCK */
+               insn_attr_t attr;
+
+               attr = inat_get_opcode_attribute(insn->prefixes.bytes[i]);
+               switch (attr) {
+               case INAT_MAKE_PREFIX(INAT_PFX_ES):
+               case INAT_MAKE_PREFIX(INAT_PFX_CS):
+               case INAT_MAKE_PREFIX(INAT_PFX_DS):
+               case INAT_MAKE_PREFIX(INAT_PFX_SS):
+               case INAT_MAKE_PREFIX(INAT_PFX_LOCK):
                        return true;
                }
        }