]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
memory: pl353-smc: Rename goto labels
authorMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 10 Jun 2021 08:20:33 +0000 (10:20 +0200)
committerKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Thu, 10 Jun 2021 15:15:16 +0000 (17:15 +0200)
A goto label is better named

        do_something:

than

        out_something_to_do:

Use the former wording and really describe what the jump involves.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/r/20210610082040.2075611-12-miquel.raynal@bootlin.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
drivers/memory/pl353-smc.c

index 2d20b1b2c0e3590e58056bfba1d973b1db455ac7..14720430bf9e67c2e9fd0f9dc88f1cd3ae826486 100644 (file)
@@ -388,7 +388,7 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
        err = clk_prepare_enable(pl353_smc->memclk);
        if (err) {
                dev_err(&adev->dev, "Unable to enable memory clock.\n");
-               goto out_clk_dis_aper;
+               goto disable_axi_clk;
        }
 
        amba_set_drvdata(adev, pl353_smc);
@@ -408,7 +408,7 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
        }
        if (!match) {
                dev_err(&adev->dev, "no matching children\n");
-               goto out_clk_disable;
+               goto disable_mem_clk;
        }
 
        init = match->data;
@@ -418,9 +418,9 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
 
        return 0;
 
-out_clk_disable:
+disable_mem_clk:
        clk_disable_unprepare(pl353_smc->memclk);
-out_clk_dis_aper:
+disable_axi_clk:
        clk_disable_unprepare(pl353_smc->aclk);
 
        return err;