]> git.proxmox.com Git - ovs.git/commitdiff
OVN: remove useless ds_clear() on actions ds
authorLorenzo Bianconi <lorenzo.bianconi@redhat.com>
Fri, 5 Jan 2018 17:52:00 +0000 (18:52 +0100)
committerBen Pfaff <blp@ovn.org>
Mon, 8 Jan 2018 16:41:41 +0000 (08:41 -0800)
Remove ds_clear() on actions dynamic string in build_acls()
since they have just been initialized to DS_EMPTY_INITIALIZER

Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
ovn/northd/ovn-northd.c

index e3ddc1fd9bc1bf29f4e4ed470c70df4c0db9ee72..63ed97efba5c469fe5930c47d016d4f97bf0be97 100644 (file)
@@ -3272,7 +3272,6 @@ build_acls(struct ovn_datapath *od, struct hmap *lflows)
                               "(!ct.est || (ct.est && ct_label.blocked == 1)) "
                               "&& (%s)",
                               acl->match);
-                ds_clear(&actions);
                 build_acl_log(&actions, acl);
                 ds_put_cstr(&actions, "/* drop */");
                 ovn_lflow_add_with_hint(lflows, od, stage,
@@ -3307,7 +3306,6 @@ build_acls(struct ovn_datapath *od, struct hmap *lflows)
                 /* There are no stateful ACLs in use on this datapath,
                  * so a "drop" ACL is simply the "drop" logical flow action
                  * in all cases. */
-                ds_clear(&actions);
                 build_acl_log(&actions, acl);
                 ds_put_cstr(&actions, "/* drop */");
                 ovn_lflow_add_with_hint(lflows, od, stage,