]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
md: flush ->event_work before stopping array.
authorNeilBrown <neilb@suse.com>
Wed, 22 Jul 2015 00:20:07 +0000 (10:20 +1000)
committerNeilBrown <neilb@suse.com>
Wed, 22 Jul 2015 04:09:29 +0000 (14:09 +1000)
The 'event_work' worker used by dm-raid may still be running
when the array is stopped.  This can result in an oops.

So flush the workqueue on which it is run after detaching
and before destroying the device.

Reported-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.com>
Cc: stable@vger.kernel.org (2.6.38+ please delay 2 weeks after -final release)
Fixes: 9d09e663d550 ("dm: raid456 basic support")
drivers/md/md.c

index df92d30ca054c68a2af9cc3ee299525d1635a0eb..5025b3ec13cddee4796f3c12d65b9edac0e93776 100644 (file)
@@ -5382,6 +5382,8 @@ static void __md_stop(struct mddev *mddev)
 {
        struct md_personality *pers = mddev->pers;
        mddev_detach(mddev);
+       /* Ensure ->event_work is done */
+       flush_workqueue(md_misc_wq);
        spin_lock(&mddev->lock);
        mddev->ready = 0;
        mddev->pers = NULL;