reference_create: validate loose names

Validate loose reference names on Win32.

diff --git a/src/refdb_fs.c b/src/refdb_fs.c
index 61d1cd56e3dbd97acc4a068860c6cd67cb19edc7..fc41a95d780871f611f4d73cbf262134e6feed3d 100644 (file)
--- a/src/refdb_fs.c
+++ b/src/refdb_fs.c
@@ -707,7 +707,7 @@ static int reference_path_available(
 
 static int loose_lock(git_filebuf *file, refdb_fs_backend *backend, const char *name)
 {
-        int error;
+       int error;
        git_buf ref_path = GIT_BUF_INIT;
 
        assert(file && backend && name);

diff --git a/tests/refs/create.c b/tests/refs/create.c
index 8e4d8d70b0af66078c2544d99a5c679f10b99826..3af7c1d151e95c5c8a4f27683a4dd6c1c9a572f7 100644 (file)
--- a/tests/refs/create.c
+++ b/tests/refs/create.c
@@ -151,13 +151,11 @@ void test_refs_create__propagate_eexists(void)
        cl_assert(error == GIT_EEXISTS);
 }
 
-void test_refs_create__creating_a_reference_with_an_invalid_name_returns_EINVALIDSPEC(void)
+static void test_invalid_name(const char *name)
 {
        git_reference *new_reference;
        git_oid id;
 
-       const char *name = "refs/heads/inv@{id";
-
        git_oid_fromstr(&id, current_master_tip);
 
        cl_assert_equal_i(GIT_EINVALIDSPEC, git_reference_create(
@@ -166,3 +164,47 @@ void test_refs_create__creating_a_reference_with_an_invalid_name_returns_EINVALI
        cl_assert_equal_i(GIT_EINVALIDSPEC, git_reference_symbolic_create(
                &new_reference, g_repo, name, current_head_target, 0, NULL, NULL));
 }
+
+void test_refs_create__creating_a_reference_with_an_invalid_name_returns_EINVALIDSPEC(void)
+{
+       test_invalid_name("refs/heads/inv@{id");
+       test_invalid_name("refs/heads/back\\slash");
+
+       test_invalid_name("refs/heads/foo ");
+       test_invalid_name("refs/heads/foo /bar");
+       test_invalid_name("refs/heads/com1:bar/foo");
+
+       test_invalid_name("refs/heads/e:");
+       test_invalid_name("refs/heads/c:/foo");
+
+       test_invalid_name("refs/heads/foo.");
+}
+
+static void test_win32_name(const char *name)
+{
+       git_reference *new_reference = NULL;
+       git_oid id;
+       int ret;
+
+       git_oid_fromstr(&id, current_master_tip);
+
+       ret = git_reference_create(&new_reference, g_repo, name, &id, 0, NULL, NULL);
+
+#ifdef GIT_WIN32
+       cl_assert_equal_i(GIT_EINVALIDSPEC, ret);
+#else
+       cl_git_pass(ret);
+#endif
+
+       git_reference_free(new_reference);
+}
+
+void test_refs_create__creating_a_loose_ref_with_invalid_windows_name(void)
+{
+       test_win32_name("refs/heads/foo./bar");
+
+       test_win32_name("refs/heads/aux");
+       test_win32_name("refs/heads/aux.foo/bar");
+
+       test_win32_name("refs/heads/com1");
+}