]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/i915: correct the input parameter on _intel_dsb_commit()
authorheminhong <heminhong@kylinos.cn>
Tue, 14 Nov 2023 02:43:41 +0000 (10:43 +0800)
committerJani Nikula <jani.nikula@intel.com>
Wed, 29 Nov 2023 17:26:05 +0000 (19:26 +0200)
Current, the dewake_scanline variable is defined as unsigned int,
an unsigned int variable that is always greater than or equal to 0.
when _intel_dsb_commit function is called by intel_dsb_commit function,
the dewake_scanline variable may have an int value.
So the dewake_scanline variable is necessary to defined as an int.

Fixes: f83b94d23770 ("drm/i915/dsb: Use DEwake to combat PkgC latency")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310052201.AnVbpgPr-lkp@intel.com/
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: heminhong <heminhong@kylinos.cn>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231114024341.14524-1-heminhong@kylinos.cn
drivers/gpu/drm/i915/display/intel_dsb.c

index 9598d50f68f22e07ff50584db3bcc2029cf4a7ea..482c28b5c2de5428f0e2a123ccbd5dc541842c7f 100644 (file)
@@ -341,7 +341,7 @@ static int intel_dsb_dewake_scanline(const struct intel_crtc_state *crtc_state)
 }
 
 static void _intel_dsb_commit(struct intel_dsb *dsb, u32 ctrl,
-                             unsigned int dewake_scanline)
+                             int dewake_scanline)
 {
        struct intel_crtc *crtc = dsb->crtc;
        struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);