]> git.proxmox.com Git - mirror_iproute2.git/commitdiff
libnetlink: Convert GETNSID dumps to use rtnl_nsiddump_req
authorDavid Ahern <dsahern@gmail.com>
Sat, 29 Sep 2018 16:51:08 +0000 (09:51 -0700)
committerDavid Ahern <dsahern@gmail.com>
Wed, 3 Oct 2018 01:39:04 +0000 (18:39 -0700)
Add rtnl_nsiddump_req for namespace id dumps using the proper rtgenmsg
as the header. Convert existing RTM_GETNSID dumps to use it.

Signed-off-by: David Ahern <dsahern@gmail.com>
include/libnetlink.h
ip/ipnetns.c
lib/libnetlink.c

index 5ccc421b4b0ec80ec5c018147c19c3a5fb5a296c..f22c92ac03dc44013a2cdee3e05dc1223396b08b 100644 (file)
@@ -63,6 +63,8 @@ int rtnl_mdbdump_req(struct rtnl_handle *rth, int family)
        __attribute__((warn_unused_result));
 int rtnl_netconfdump_req(struct rtnl_handle *rth, int family)
        __attribute__((warn_unused_result));
+int rtnl_nsiddump_req(struct rtnl_handle *rth, int family)
+       __attribute__((warn_unused_result));
 
 int rtnl_wilddump_request(struct rtnl_handle *rth, int fam, int type)
        __attribute__((warn_unused_result));
index 368be0cbc0a48971f236621230aef25c9291f384..e8500c77399485a724992a68be3ae91579ae5afe 100644 (file)
@@ -346,7 +346,7 @@ static int netns_list_id(int argc, char **argv)
                return -ENOTSUP;
        }
 
-       if (rtnl_wilddump_request(&rth, AF_UNSPEC, RTM_GETNSID) < 0) {
+       if (rtnl_nsiddump_req(&rth, AF_UNSPEC) < 0) {
                perror("Cannot send dump request");
                exit(1);
        }
index c28047e4b055d856e9818702a5270a913b13ea07..2dd14ac5ea58fb089bfc803e1e25144dc82b642b 100644 (file)
@@ -330,6 +330,22 @@ int rtnl_netconfdump_req(struct rtnl_handle *rth, int family)
        return send(rth->fd, &req, sizeof(req), 0);
 }
 
+int rtnl_nsiddump_req(struct rtnl_handle *rth, int family)
+{
+       struct {
+               struct nlmsghdr nlh;
+               struct rtgenmsg rtm;
+       } req = {
+               .nlh.nlmsg_len = sizeof(req),
+               .nlh.nlmsg_type = RTM_GETNSID,
+               .nlh.nlmsg_flags = NLM_F_DUMP | NLM_F_REQUEST,
+               .nlh.nlmsg_seq = rth->dump = ++rth->seq,
+               .rtm.rtgen_family = family,
+       };
+
+       return send(rth->fd, &req, sizeof(req), 0);
+}
+
 int rtnl_wilddump_request(struct rtnl_handle *rth, int family, int type)
 {
        return rtnl_wilddump_req_filter(rth, family, type, RTEXT_FILTER_VF);