]> git.proxmox.com Git - fwupd.git/commitdiff
analogix: Do not check the endpoints before selecting an interface
authorRichard Hughes <richard@hughsie.com>
Mon, 6 Feb 2023 15:00:49 +0000 (15:00 +0000)
committerRichard Hughes <richard@hughsie.com>
Fri, 10 Feb 2023 10:52:58 +0000 (10:52 +0000)
My Analogix USB device has a Billboard interface, with bNumEndpoints=0.

When emulating the interface is NULL, and in runtime the array can *never* be
NULL, so I think this check was added in error.

plugins/analogix/fu-analogix-device.c

index bbfe18ae2be70e4146a819e9f4ccc3b0e3ec1799..5c69d6e94d6246bbb93a7cb26c5c082a860abbcd 100644 (file)
@@ -208,11 +208,6 @@ fu_analogix_device_find_interface(FuUsbDevice *device, GError **error)
                if (g_usb_interface_get_class(intf) == BILLBOARD_CLASS &&
                    g_usb_interface_get_subclass(intf) == BILLBOARD_SUBCLASS &&
                    g_usb_interface_get_protocol(intf) == BILLBOARD_PROTOCOL) {
-                       g_autoptr(GPtrArray) endpoints = NULL;
-
-                       endpoints = g_usb_interface_get_endpoints(intf);
-                       if (endpoints == NULL)
-                               continue;
                        fu_usb_device_add_interface(FU_USB_DEVICE(self),
                                                    g_usb_interface_get_number(intf));
                        return TRUE;