]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
net: greth: use phy_read_status()
authorFlorian Fainelli <f.fainelli@gmail.com>
Fri, 6 Dec 2013 21:01:32 +0000 (13:01 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 10 Dec 2013 01:38:58 +0000 (20:38 -0500)
In case the greth driver is bound to anything but the Generic PHY
driver or the PHY has a special read_status callback implemented,
unexpected things will happen. Make sure we that we use
phy_read_status() which does the proper abstraction of calling the
driver specific read_status() callback for a given PHY.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aeroflex/greth.c

index e0669455514458705fc5a321b1a82efb13891c2c..b20cbf0323e0ff4f87e852da3679002757862d39 100644 (file)
@@ -1361,7 +1361,7 @@ static int greth_mdio_init(struct greth_private *greth)
                timeout = jiffies + 6*HZ;
                while (!phy_aneg_done(greth->phy) && time_before(jiffies, timeout)) {
                }
-               genphy_read_status(greth->phy);
+               phy_read_status(greth->phy);
                greth_link_change(greth->netdev);
        }